Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Supplier ID in Test JSON #7

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Conversation

tgeeting
Copy link

Supplier ID needs to be updated to 20 in all TripleLift related Test JSON files.

https://travis-ci.org/prebid/prebid-server/jobs/601297448?utm_medium=notification&utm_source=github_status
(Travie made a boo boo).

@tgeeting tgeeting requested a review from Kevin-P-Kerr October 23, 2019 20:53
@@ -1,114 +1,144 @@
{
"mockBidRequest": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this test in particular so different?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not, VSCode just auto-formatted the JSON indents to 2 spaces 🤷‍♂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you ./validate.sh

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that will format the ws in the standard way

@Kevin-P-Kerr Kevin-P-Kerr merged commit a46b041 into master Oct 24, 2019
@Kevin-P-Kerr Kevin-P-Kerr deleted the fix-supplier-id-broken-tests branch October 24, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants